-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Designs] Update Dashboard view to match new design #631
Conversation
…d add a `ViewModel` for state management
@agrabeli , We have been showing |
Thanks @aanorbel for your question (though I feel like I may be missing some context). Is the goal to display (for example) Overall, why is this change needed? While I can see that perhaps having "obscure" experiment names is not preferable from a UX perspective, at the same time it may be more interesting to see (for example) that "the WhatsApp test is running, the Signal test is running..." than "Instant Messaging running"... |
The new design calls for the test suite to be used instead of the test name. Wanted to know which side you're on. |
@aanorbel I'd personally prefer keeping the test names in the progress bar as I personally like seeing which experiment is running, and which experiment doesn't run (for example, due to network issues etc). I also find it more informative seeing that (for example) "WhatsApp is running" than "Instant Messaging is running" (though I realize that not everyone is familiar with the test names, and that some test names are not very descriptive). But if the consensus is to replace the test names with the test suites, we could do that. |
I second what @agrabeli write. In case of bugs, it helps us to know what was failing. "The app crashed while running WhatsApp" is more actionable than "the app crashed whole it was running Instant Messaging". I think the main reason why this issue popped up is because the "Websites" group says "Web Connectivity". I would not be opposed to replace "Web Connectivity" with "Websites" because there's a 1:1 mapping. On further reflection, for IM it definitely makes sense to keep the test names explicit because people know about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor changes
app/src/main/java/org/openobservatory/ooniprobe/activity/MainActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/adapters/DashboardAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/fragment/ProgressFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/fragment/ProgressFragment.kt
Outdated
Show resolved
Hide resolved
## Release Note - Measurement engine synced with OONI Probe CLI [v3.19.1](https://github.com/ooni/probe-cli/releases/tag/v3.19.1) - Bug fixes and Improvements
## Proposed Changes - Move riseupvpn to experimental suite - Correct tests appropriately. |.|.| |-|-| | ![Screenshot_20231124_201232](https://github.com/ooni/probe-android/assets/17911892/8cd73191-d1b3-444f-b44e-b59e3847f1e3) | ![Screenshot_20231124_201328](https://github.com/ooni/probe-android/assets/17911892/1a259298-d6bc-46e1-87be-fb24dedeb220)|
## Proposed Changes - Replace `HeterogeneousRecyclerAdapter` with `RecyclerView.Adapter` - Add a `ViewModel` for state management
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐳
Fixes ooni/probe#2588
Proposed Changes
ProgressFragment
to kotlin