Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Designs] Update Test overview to remove run button and implement new components #629

Merged
merged 9 commits into from
Nov 24, 2023
Merged

[New Designs] Update Test overview to remove run button and implement new components #629

merged 9 commits into from
Nov 24, 2023

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Oct 25, 2023 •
edited
Loading

Fixes ooni/probe#2591

Proposed Changes

  • Removes Run button.
  • Adds Read more > plugin to markdown text
. .
Screenshot_20231031_205420 Screenshot_20231031_205432
Screenshot_20231031_205456 Screenshot_20231031_205442

@aanorbel aanorbel changed the base branch from master to chore/gradle-kotlin-upgrade October 25, 2023 19:37
@aanorbel aanorbel marked this pull request as ready for review October 31, 2023 19:30
bassosimone
bassosimone approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳 but maybe we should cleanup the code a bit by avoiding if (true) and instead just putting the code inside the true branch inline.

app/src/main/java/org/openobservatory/ooniprobe/common/ReadMorePlugin.kt Outdated Show resolved Hide resolved
app/src/main/java/org/openobservatory/ooniprobe/common/ReadMorePlugin.kt Outdated Show resolved Hide resolved
Base automatically changed from chore/gradle-kotlin-upgrade to master November 3, 2023 07:33
@aanorbel aanorbel changed the base branch from master to dev/design-update November 24, 2023 14:11
@aanorbel aanorbel merged commit 0bf531c into dev/design-update Nov 24, 2023
5 checks passed
@aanorbel aanorbel deleted the issues/2591 branch November 24, 2023 17:20
@aanorbel aanorbel mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Designs] Update Test overview to remove run button and implement new components
2 participants
@aanorbel @bassosimone