-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/riseupvpn config #832
Conversation
Add comment on future work needed to upgrade to newer pattern
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #832 +/- ##
===========================================
- Coverage 100.00% 99.88% -0.12%
===========================================
Files 21 27 +6
Lines 1439 1771 +332
Branches 116 143 +27
===========================================
+ Hits 1439 1769 +330
- Misses 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, this is minimal and great to test the experiment; left some comments for future improvements since we have some of the discussion fresh.
the only change I see would be to reduce the frequency to a day (or less) so that we can test the updates.
to minimize migrations, perhaps it'd be good to deploy & test this branch and then pile up changes like metadata and perhaps a nicer abstraction for organizing measurement turnover. I'd suggest to have a conversation about that after landing the probe-cli experiment.
Create new ooniprobe service to support OpenVPN experiment.
Add experimental entrypoint to provision credentials to OpenVPN experiment.
This superseeds: #830