Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/riseupvpn config #832

Merged
merged 33 commits into from
Apr 8, 2024
Merged

Feature/riseupvpn config #832

merged 33 commits into from
Apr 8, 2024

Conversation

hellais
Copy link
Member

@hellais hellais commented Mar 28, 2024

Create new ooniprobe service to support OpenVPN experiment.

Add experimental entrypoint to provision credentials to OpenVPN experiment.

  • Single provider (riseup) for the MVP.
  • Configurable "freshness" parameter to limit the query.
  • Stub for inserting new credentials periodically.

This superseeds: #830

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 99.48320% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.88%. Comparing base (e486936) to head (c01c576).
Report is 3 commits behind head on master.

❗ Current head c01c576 differs from pull request most recent head e99162c. Consider uploading reports for the commit e99162c to get more accurate results

Files Patch % Lines
...api/services/ooniprobe/src/ooniprobe/routers/v2.py 96.61% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #832      +/-   ##
===========================================
- Coverage   100.00%   99.88%   -0.12%     
===========================================
  Files           21       27       +6     
  Lines         1439     1771     +332     
  Branches       116      143      +27     
===========================================
+ Hits          1439     1769     +330     
- Misses           0        2       +2     
Flag Coverage Δ
ooniauth 100.00% <ø> (ø)
ooniprobe 99.47% <99.47%> (?)
oonirun 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ainghazal ainghazal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, this is minimal and great to test the experiment; left some comments for future improvements since we have some of the discussion fresh.

the only change I see would be to reduce the frequency to a day (or less) so that we can test the updates.

to minimize migrations, perhaps it'd be good to deploy & test this branch and then pile up changes like metadata and perhaps a nicer abstraction for organizing measurement turnover. I'd suggest to have a conversation about that after landing the probe-cli experiment.

@hellais hellais merged commit 33ddfd9 into master Apr 8, 2024
5 checks passed
@hellais hellais deleted the feature/riseupvpn-config branch April 8, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants