feat: 🎸 added support for differnt pem/der encodings #51
+31
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple options are tested and the first working import method is picked
|
Looks good. Might add a extra DER encoded key to the test resources. |
benjaminbruun
approved these changes
Jan 10, 2024
|
good point. I'll wait until we know if this actually resolves any errors or not. I got a feeling that the pcks8 is a more modern format so hopefully we'll run into fewer problems with that as an option. |
alexdor
reviewed
Feb 23, 2024
Comment on lines
+41
to
+47
| } else { | ||
| for key in &keys { | ||
| log::trace!("{:?}", key); | ||
| } | ||
|
|
||
| Err("Failed to decode private key. Is the key corrupted?".into()) | ||
| } |
There was a problem hiding this comment.
Suggested change
| } else { | |
| for key in &keys { | |
| log::trace!("{:?}", key); | |
| } | |
| Err("Failed to decode private key. Is the key corrupted?".into()) | |
| } | |
| } | |
| for key in &keys { | |
| log::trace!("{:?}", key); | |
| } | |
| Err("Failed to decode private key. Is the key corrupted?".into()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple options are tested and the first working import method is picked