Remove element type restriction in softmax lowering #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam <[email protected]>
|
Let me know if you want me to merge it @srcarroll |
thanks. yes please |
|
Jenkins Linux ppc64le Build #15190 [push] Remove element type rest... started at 12:32 |
|
Jenkins Linux amd64 Build #16161 [push] Remove element type rest... started at 11:13 |
|
Jenkins Linux s390x Build #16163 [push] Remove element type rest... started at 12:13 |
|
Jenkins Linux amd64 Build #16161 [push] Remove element type rest... passed after 1 hr 17 min |
|
Jenkins Linux s390x Build #16163 [push] Remove element type rest... passed after 1 hr 39 min |
|
Jenkins Linux ppc64le Build #15190 [push] Remove element type rest... passed after 2 hr 25 min |
christopherlmunoz
pushed a commit
to christopherlmunoz/onnx-mlir
that referenced
this pull request
Jan 30, 2025
Signed-off-by: Sam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the assertion that input element type is
f32in the softmax to stablehlo lowering. There appears to be no good reason for this restriction as stablehlo supports more types.The original
Softmax.mlirtest has been renamed toSoftmax-Decompose.mlirand replaced by a new one the leaves out thedecompose-onnxpass. The primary reason for this is to be able to testbf16lowering which is still not supported by the decomposition. An error is thrown while computing the identity for max reduction (see https://github.com/onnx/onnx-mlir/blob/main/src/Dialect/Mlir/DialectBuilder.cpp#L698). Since downstream users don't necessarily need the decomposition it suffices to test without it for now. However, plans to support lower precision types elsewhere is a todo.Note: The decomposition does stabilize softmax to prevent overflow, which is especially important for lower precision. Nevertheless, the straight conversion should allow it if people to choose to opt out of the decomp.