Fix a first character problem in IME with autoClosingPairs.enabled (#…

…2341)
onivim · Jun 21, 2018 · 633d838 · 633d838
1 parent 7ebdfea
commit 633d838
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/browser/src/UI/Shell/ShellView.tsx b/browser/src/UI/Shell/ShellView.tsx
@@ -83,8 +83,16 @@ export class ShellView extends React.PureComponent<IShellViewComponentProps, ISh
     }
 
     private _onRootKeyDown(evt: React.KeyboardEvent<HTMLElement>): void {
+        // onCompositionStart can't detect composing mode for the first character
+        // because it is fired after onKeyDown.
+        // keyCode is deprecated but it seems this is the only method to detect
+        // composing mode for the first character for now.
+        let isComposing = false
+        if (evt.keyCode === 229) {
+            isComposing = true
+        }
         const vimKey = inputManager.resolvers.resolveKeyEvent(evt.nativeEvent)
-        if (!this.state.isComposing && inputManager.handleKey(vimKey)) {
+        if (!this.state.isComposing && !isComposing && inputManager.handleKey(vimKey)) {
             evt.stopPropagation()
             evt.preventDefault()
         } else {