first stab at adding nft license view

[bjartek]

I added methods for each of the 12 combinations.

Not really sure what we should expose from the struct or if this way of creating it is the best way.

Description

---

For contributor use:

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the standards mentioned here.
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

• Update the version in package.json when there is a change in the smart contracts

[joshuahannan]

Thanks for taking a stab! I was a little confused about how you implemented it at first, but after thinking about it, I think it makes sense and allows us to add more combinations in the future if needed. I'm wondering if it also would be nice to also include a description like we did in the proposal that I made in the other issue.

And also similar to that proposal, we want to include a Media for each right to potentially link to an off-chain description of the rights or this "badge" that is mentioned in the proposal.

I'm happy to make those changes and add some tests, though I'm not sure the best way to do it since this is in your fork. Can I just copy your code to my branch?

[joshuahannan]

Suggested change

	if let vTiew = viewResolver.resolveView(Type<Rarity>()) {
	if let view = viewResolver.resolveView(Type<Rarity>()) {

[bjartek]

Thanks for taking a stab! I was a little confused about how you implemented it at first, but after thinking about it, I think it makes sense and allows us to add more combinations in the future if needed. I'm wondering if it also would be nice to also include a description like we did in the proposal that I made in the other issue.

And also similar to that proposal, we want to include a Media for each right to potentially link to an off-chain description of the rights or this "badge" that is mentioned in the proposal.

I'm happy to make those changes and add some tests, though I'm not sure the best way to do it since this is in your fork. Can I just copy your code to my branch?

Feel free to copy

[joshuahannan]

I opened a new PR with my suggestions: #173

I'll close this for now in favor of that one. Please leave feedback when you get the chance! Thank you. :)