Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more block & tx related endpoints #43

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Feb 7, 2024

Builds upon: #42
Closes: #4
Closes: #5

Description

Implements more block & transaction related JSON-RPC endpoints

These include:

  • eth_getBlockByHash
  • eth_getBlockTransactionCountByHash
  • eth_getBlockTransactionCountByNumber
  • eth_getTransactionByBlockHashAndIndex
  • eth_getTransactionByBlockNumberAndIndex

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

These include:
- eth_getBlockByHash
- eth_getBlockTransactionCountByHash
- eth_getBlockTransactionCountByNumber
- eth_getTransactionByBlockHashAndIndex
- eth_getTransactionByBlockNumberAndIndex
@m-Peter m-Peter added this to the Flow-EVM-M2 milestone Feb 7, 2024
@m-Peter m-Peter self-assigned this Feb 7, 2024
@m-Peter m-Peter marked this pull request as ready for review February 7, 2024 19:46
@m-Peter m-Peter requested a review from devbugging February 7, 2024 19:46
@m-Peter m-Peter merged commit 0b6d8ab into onflow:main Feb 8, 2024
1 check passed
@m-Peter m-Peter deleted the block-and-tx-related-endpoints branch February 8, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
2 participants