Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify C compiler in build cross-compilation #548

Merged
merged 30 commits into from
Feb 16, 2024
Merged

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Jan 10, 2024

Closes #534

Description

  • remove unused Dockerfile.relic
  • update Dockerfile go build step:
    • enable cgo.
    • specify the C compiler for each arch target. This insures cross-compilation of the crypto non-portable code succeeds.
    • disable ADX instructions when compiling the crypto lib: crypto operations become slower but it makes sure binary can run on all CPUs.

Builds were enabled temporarily while working on the PR. You can see the results here.


For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91908ef) 53.68% compared to head (4ff4de9) 53.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #548   +/-   ##
=======================================
  Coverage   53.68%   53.68%           
=======================================
  Files          31       31           
  Lines        3962     3962           
=======================================
  Hits         2127     2127           
  Misses       1672     1672           
  Partials      163      163           
Flag Coverage Δ
unittests 53.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/emulator/Dockerfile Outdated Show resolved Hide resolved
@tarakby tarakby mentioned this pull request Jan 12, 2024
@tarakby tarakby changed the title WIP Specify C compiler in build cross-compilation Jan 12, 2024
@tarakby tarakby marked this pull request as ready for review January 12, 2024 20:10
@tarakby tarakby self-assigned this Jan 12, 2024
@tarakby tarakby added the Bugfix label Jan 12, 2024
@tarakby
Copy link
Contributor Author

tarakby commented Jan 12, 2024

Builds were enabled temporarily while working on the PR. You can see the results here.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/emulator/Dockerfile Outdated Show resolved Hide resolved
@tarakby tarakby merged commit 24e84ab into master Feb 16, 2024
3 checks passed
@tarakby tarakby deleted the tarak/fix-build branch February 16, 2024 16:00
jribbink pushed a commit that referenced this pull request Mar 7, 2024
Specify C compiler in build cross-compilation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker builds are broken
7 participants