Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest flow-go #516

Closed
wants to merge 6 commits into from
Closed

Update to latest flow-go #516

wants to merge 6 commits into from

Conversation

devbugging
Copy link
Contributor

Description

Update to latest version of flow-go


For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f1e6dd6) 50.75% compared to head (676cf39) 50.71%.

Files Patch % Lines
server/access/streamBackend.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   50.75%   50.71%   -0.04%     
==========================================
  Files          30       30              
  Lines        3933     3936       +3     
==========================================
  Hits         1996     1996              
- Misses       1784     1787       +3     
  Partials      153      153              
Flag Coverage Δ
unittests 50.71% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gregor Gololicic added 2 commits November 29, 2023 12:04
@peterargue
Copy link
Contributor

these changes were addressed in #518

@devbugging devbugging closed this Nov 30, 2023
@devbugging devbugging deleted the gregor/update-flow-go branch December 20, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants