Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use core contract list from flow-go #513

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Use core contract list from flow-go #513

merged 4 commits into from
Nov 30, 2023

Conversation

janezpodhostnik
Copy link
Contributor

@janezpodhostnik janezpodhostnik commented Nov 21, 2023 •
edited
Loading

Description

Use the new SystemContracts.All() to get the contracts deploy at bootstrapping.

This is related to: onflow/flow-go#5033

For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@janezpodhostnik janezpodhostnik self-assigned this Nov 21, 2023
devbugging
devbugging approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@devbugging devbugging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@chasefleming
Copy link
Member

This is handy! Needed this for other repos. Awesome.

bluesign
bluesign approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@bluesign bluesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

@janezpodhostnik janezpodhostnik force-pushed the janez/use-core-contract-list-from-flow-go branch from e86d5ad to f5b2fac Compare November 30, 2023 13:57
@janezpodhostnik janezpodhostnik merged commit f22e543 into master Nov 30, 2023
3 checks passed
@janezpodhostnik janezpodhostnik deleted the janez/use-core-contract-list-from-flow-go branch November 30, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbugging devbugging devbugging approved these changes

@chasefleming chasefleming chasefleming approved these changes

@bluesign bluesign bluesign approved these changes

@turbolent turbolent turbolent approved these changes

Assignees

@janezpodhostnik janezpodhostnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@janezpodhostnik @chasefleming @turbolent @bluesign @devbugging