Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cadence v0.42.5 #1264

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Conversation

turbolent
Copy link
Member

@turbolent turbolent changed the title Auto update to onflow/cadence v0.42.5 Update to Cadence v0.42.5 Nov 10, 2023
@turbolent
Copy link
Member Author

@m-Peter Do the changes to the test tests in 11bfd48 look OK?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (465f9fc) 41.19% compared to head (11bfd48) 41.19%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1264   +/-   ##
=======================================
  Coverage   41.19%   41.19%           
=======================================
  Files          39       39           
  Lines        2068     2068           
=======================================
  Hits          852      852           
  Misses       1123     1123           
  Partials       93       93           
Flag Coverage Δ
unittests 41.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@m-Peter m-Peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 🚀

@m-Peter
Copy link
Collaborator

m-Peter commented Nov 11, 2023

@turbolent The changes look good 💯 👏
System contracts (RandomBeaconHistory) and utility locations (BlockchainHelpers) are expected to be excluded from coverage reports. I forgot to exclude the BlockchainHelpers in the previous release, hence the change in the code coverage percentage on the test cases.

@chasefleming chasefleming merged commit 1e30508 into master Nov 13, 2023
@chasefleming chasefleming deleted the auto-update-onflow-cadence-v0.42.5 branch November 13, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants