Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fees.md #626

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Update fees.md #626

merged 1 commit into from
Mar 1, 2024

Conversation

KshitijChaudhary666
Copy link
Contributor

Adding FlowEVM gas fee details to this doc

Adding FlowEVM gas fee details to this doc
Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 9:46pm

@franklywatson franklywatson merged commit f769a14 into main Mar 1, 2024
3 checks passed
@franklywatson franklywatson deleted the KshitijChaudhary666-patch-1 branch March 1, 2024 22:42
@@ -20,4 +20,108 @@ Transactions on FlowEVM are executed through Cadence, which uses FLOW token for

For transactions that are submitted to a FlowEVM RPC node, the RPC node wraps the EVM transaction in a Cadence transaction and signs that transaction as the Payer. The coinbase of the EVM transaction is set by the RPC node to an address it maintains, therefore billing the cost of the transaction to the address executing it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change FlowEVM to EVM here and add 'an'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The info bubble at the top also says "Are you a Cadence developer looking for information about Accounts on Cadence? If so, check out the Cadence specific documentation here", let's change it from Accounts to 'Fees'

![FlowEVM-RPC-Payer](flow-rpc-payer.drawio.png)

# How gas fees work on FlowEVM?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be consistent - capital case

# How gas fees work on FlowEVM?

## Revisiting Transaction Fee on Flow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would update to either 'Fees' or 'The Transaction Fee'

`Transaction fee = [inclusion fee + (execution effort * unit cost)] x surge`

where,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'where,' is a bit awkward here

- Surge = 1.0 (currently constant)

## Transaction fee on FlowEVM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not use FlowEVM -> Transaction Fees on EVM

### EVMGasUsageCost

Looking through past EVM contract deployments, a robust estimate is that one Flow Cadence transaction should be able to fit up to 10M gas. For Cresendo PreviewNet launch therefore, given the current computation limit on Flow being 9999, we would use the conversion ratio of 1000 gas/computation. Thus EVMGasUsageCost will initially be fixed at 1/1000, but will be open for revision prior to the Mainnet launch and in future.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crescendo PreviewNet -> Previewnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants