Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nialexsan/remove cadence #438

Merged
merged 14 commits into from
Nov 9, 2023
Merged

Nialexsan/remove cadence #438

merged 14 commits into from
Nov 9, 2023

Conversation

nialexsan
Copy link
Collaborator

@nialexsan nialexsan commented Nov 7, 2023 •
edited
Loading

removed cadence docs and set up redirects to https://cadence-lang.org/docs/0.42/

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 5:57pm

@turbolent
Copy link
Member

turbolent commented Nov 7, 2023 •
edited by nialexsan
Loading

Blocked on #439

@nialexsan
Copy link
Collaborator Author

nialexsan commented Nov 8, 2023 •
edited
Loading

blocked by onflow/cadence-lang.org#17

@nialexsan nialexsan marked this pull request as ready for review November 8, 2023 17:50
@nialexsan nialexsan requested a review from a team as a code owner November 8, 2023 17:50
@nialexsan nialexsan mentioned this pull request Nov 8, 2023
Closed
@nialexsan nialexsan requested a review from bthaile November 9, 2023 14:12
turbolent
turbolent reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

The only thing left to be done is to redirect to just /docs, not /docs/0.42 anymore. This changed recently, so that links don't become outdated, but always point to the currently released docs by default.

@nialexsan nialexsan requested a review from turbolent November 9, 2023 17:59
@nialexsan
Copy link
Collaborator Author

@turbolent, fixed the redirect and links

turbolent
turbolent approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@turbolent turbolent merged commit c0ca5ee into main Nov 9, 2023
2 checks passed
@turbolent turbolent deleted the nialexsan/remove-cadence branch November 9, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@bthaile bthaile Awaiting requested review from bthaile

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nialexsan @turbolent