Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stable cadence branch #39

Merged
merged 22 commits into from
Jul 29, 2024
Merged

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Jul 26, 2024

Description

Updates stable-cadence feature branch with changes from main


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling added the enhancement New feature or request label Jul 26, 2024
@sisyphusSmiling sisyphusSmiling self-assigned this Jul 26, 2024
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review July 26, 2024 22:32
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner July 26, 2024 22:32
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.14%. Comparing base (c99c1a9) to head (7838613).

Files Patch % Lines
contracts/DependencyAudit.cdc 87.50% 7 Missing ⚠️
contracts/MigrationContractStaging.cdc 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           stable-cadence      #39      +/-   ##
==================================================
+ Coverage           83.89%   84.14%   +0.25%     
==================================================
  Files                   6        6              
  Lines                 298      347      +49     
==================================================
+ Hits                  250      292      +42     
- Misses                 48       55       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling merged commit 3e614c1 into stable-cadence Jul 29, 2024
1 check passed
@sisyphusSmiling sisyphusSmiling deleted the update-stable-cadence branch July 29, 2024 23:48
@sisyphusSmiling
Copy link
Contributor Author

sisyphusSmiling commented Jul 29, 2024

@janezpodhostnik do you know if DependencyAudit is staged with these updates or is the migration of that handled natively?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants