ON-39881 # Changed email attachment filename to all lowercase

oneblink · Apr 26, 2024 · 1621330 · 1621330
1 parent b27d9ba
commit 1621330
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/OneBlinkUploader.ts b/src/OneBlinkUploader.ts
@@ -431,7 +431,7 @@ export default class OneBlinkUploader {
     abortSignal,
     data,
     contentType,
-    fileName,
+    filename,
   }: UploadOptions & UploadEmailAttachmentOptions) {
     return await uploadToS3({
       ...this,
@@ -441,7 +441,7 @@ export default class OneBlinkUploader {
       abortSignal,
       onProgress,
       requestBodyHeader: {
-        fileName,
+        filename,
       },
       isPublic: false,
     })

diff --git a/src/types.ts b/src/types.ts
@@ -49,11 +49,14 @@ export type UploadFormSubmissionOptions = UploadOptions & {
   jobId?: string
 }
 
-export type UploadAssetOptions = UploadOptions & {
+export type UploadAssetBase = {
   /** The file data to upload */
   data: AttachmentUploadData
   /** A standard MIME type describing the format of the contents */
   contentType: string
+}
+
+export type UploadAssetOptions = UploadAssetBase & {
   /** The name of the file being uploaded */
   fileName: string
 }
@@ -65,4 +68,7 @@ export type UploadPDFConversionOptions = UploadOptions & {
   formId: number
 }
 
-export type UploadEmailAttachmentOptions = UploadAssetOptions
+export type UploadEmailAttachmentOptions = UploadAssetBase & {
+  /** The name of the file being uploaded */
+  filename: string
+}