Skip to content
This repository has been archived by the owner on Nov 13, 2020. It is now read-only.

ANALYTICS-133 # Some guidelines for contributing and a Code of Conduct #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ANALYTICS-133 # Some guidelines for contributing and a Code of Conduct #3

wants to merge 2 commits into from

Conversation

k7n4n5t3w4rt
Copy link
Contributor

No description provided.

mymattcarroll
mymattcarroll suggested changes Jul 4, 2017
View reviewed changes
CONTRIBUTING.md Outdated
@@ -1 +1,91 @@
# Contributing
# Contributing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contributing twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oop.

CONTRIBUTING.md Outdated
1. Ensure any install or build dependencies are removed before the end of the layer when doing a
build.
2. Update the CHANGELOG.md with details of changes.
3. Increase the version numbers in the package.json to the new version that this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we want people changing our version. We should be handling that during our release process in my opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right on.

@mymattcarroll
Copy link
Contributor

LGTM 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mymattcarroll mymattcarroll mymattcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k7n4n5t3w4rt @mymattcarroll