Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zero_interest_installments option from installment banks other than Maybank #458

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

aashishgurung
Copy link
Contributor

@aashishgurung aashishgurung commented Nov 24, 2023

1. Objective

Remove zero_interest_installments option from installment banks other than Maybank

2. Description of change

Updated logic to set zero_interest_installments only for installment Maybank

3. Quality assurance

Specify where and how you tested this and what further testing it might need.

🔧 Environments:

  • Platform version: Magento CE 2.4.5
  • Omise plugin version: Omise-Magento 3.5.0
  • PHP version: 8.1.21

✏️ Details:

Create a charge with installments

4. Impact of the change

It should resolve the issue of customer absorbing the interest rate when it should be merchant.

5. Priority of change

High

6. Additional Notes

Any further information that you would like to add.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@aashishgurung aashishgurung merged commit e5f255e into develop Nov 24, 2023
6 checks passed
@aashishgurung aashishgurung deleted the bug/MIT-2091-installment-interest-rate branch November 24, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants