Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated OCBC digital logo #457

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Updated OCBC digital logo #457

merged 2 commits into from
Nov 17, 2023

Conversation

aashishgurung
Copy link
Contributor

@aashishgurung aashishgurung commented Nov 17, 2023

1. Objective

Update OCBC digital logo

2. Description of change

Replaced "ocbc_digital.png" with "ocbc_digital.svg". Updated code to reflect this change.

Screenshot 2566-11-17 at 14 13 31

3. Quality assurance

Specify where and how you tested this and what further testing it might need.

🔧 Environments:

Platform version: Magento CE 2.4.5
Omise plugin version: Omise-Magento 3.1.2
PHP version: 8.1.21

✏️ Details:

Confirm that you see the new OCBC digital logo on checkout page

4. Impact of the change

No impact

5. Priority of change

Normal

6. Additional Notes

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aashishgurung aashishgurung merged commit 0a29929 into develop Nov 17, 2023
6 checks passed
@aashishgurung aashishgurung deleted the update_ocbc_digital_logo branch November 17, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants