Overall Output Limit #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frcepeda
commented
Apr 30, 2022
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 41.13% 41.35% +0.22%
==========================================
Files 25 25
Lines 6683 6717 +34
==========================================
+ Hits 2749 2778 +29
- Misses 3677 3681 +4
- Partials 257 258 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
frcepeda
commented
May 1, 2022
| @@ -143,7 +143,7 @@ var ( | |||
| MemoryLimit: base.Gibibyte + base.Gibibyte/2, | |||
| OverallWallTimeLimit: base.Duration(time.Duration(10) * time.Second), | |||
| ExtraWallTime: base.Duration(0), | |||
| OutputLimit: base.Byte(2) * base.Mebibyte, | |||
| OutputLimit: base.Byte(20) * base.Mebibyte, | |||
There was a problem hiding this comment.
Lo dejé en 20—la cosa es que luego sí hay problemas con casos grandotes que omegaUp no ha podido soportar por esto. (O supongo 10 está bien pero reevaluar si seguimos topándonos con este límite; 2 MiB definitivamente era muy poquito)
|
@lhchavez hay algo que falte para hacer check-in? la verdad se me olvidó darle seguimiento al PR |
lhchavez
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intento de resolver #32. La idea es que se valga tener archivos grandes, nomás no muchos.
(De hecho esto es mejoría: creo que no había impedimento de, digamos, hacer un problema con 100 casos que corran súper rápido con output de 2MiB cada uno)