Skip to content

Commit

Permalink
vPCI: fix MSI-X PBA read/write gprintk()s
Browse files Browse the repository at this point in the history
%pp wants the address of an SBDF, not that of a PCI device.

Fixes: b4f2116 ("vpci/msix: fix PBA accesses")
Signed-off-by: Jan Beulich <[email protected]>
Reviewed-by: Roger Pau Monné <[email protected]>
master commit: d3f61be
master date: 2022-04-07 18:01:24 +0200
  • Loading branch information
jbeulich committed Apr 8, 2022
1 parent 5a4935b commit 44aae67
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions xen/drivers/vpci/msix.c
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ static int msix_read(struct vcpu *v, unsigned long addr, unsigned int len,
{
gprintk(XENLOG_WARNING,
"%pp: unable to map MSI-X PBA, report all pending\n",
msix->pdev);
&msix->pdev->sbdf);
return X86EMUL_OKAY;
}

Expand Down Expand Up @@ -331,7 +331,7 @@ static int msix_write(struct vcpu *v, unsigned long addr, unsigned int len,
/* Unable to map the PBA, ignore write. */
gprintk(XENLOG_WARNING,
"%pp: unable to map MSI-X PBA, write ignored\n",
msix->pdev);
&msix->pdev->sbdf);
return X86EMUL_OKAY;
}

Expand Down

0 comments on commit 44aae67

Please sign in to comment.