Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource for email template settings #2170

Closed
wants to merge 2 commits into from

Conversation

s-nel
Copy link
Contributor

@s-nel s-nel commented Jan 10, 2025

This PR adds a TF resource to manage Okta email template settings (API docs here). The email template settings can be used to control the recipients of different emails.

This is my first time writing a resource, so please review thoroughly 😁

Fixes: #2169

@s-nel s-nel force-pushed the email-template-settings-resource branch from bbfab4b to 4d23e3b Compare January 10, 2025 06:19
@duytiennguyen-okta
Copy link
Contributor

Hi @s-nel. Thank you for you effort. Can you move from using plugin_sdk to plugin_framework? We are trying to move away from the plugin_sdk as it is outdated. An example can be found here

@s-nel
Copy link
Contributor Author

s-nel commented Jan 15, 2025

Hi @s-nel. Thank you for you effort. Can you move from using plugin_sdk to plugin_framework? We are trying to move away from the plugin_sdk as it is outdated. An example can be found here

Done. I had trouble running the VCR recorded test for plugin framework resources. The plugin SDK ones work fine, but the plugin framework throw dial tcp: lookup oie-00.dne-okta.com: no such host. Is there a different way to run these tests with VCR?

@duytiennguyen-okta
Copy link
Contributor

@s-nel currently the VCR has not been setup to run the plugin framework. As long as your test run, you should be fine

@duytiennguyen-okta
Copy link
Contributor

There is some issue with your code so I bring it in #2179. Close in favor of #2179

@s-nel
Copy link
Contributor Author

s-nel commented Jan 20, 2025

Thanks for your help 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource for email template settings
2 participants