Skip to content
This repository has been archived by the owner on Jan 26, 2025. It is now read-only.

chore[oidc-middleware]: Updating UUID version #1010

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/oidc-middleware/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"node-fetch": "^2.3.0",
"openid-client": "3.12.2",
"passport": "^0.4.1",
"uuid": "^3.1.0"
"uuid": "^8.3.2"
},
"devDependencies": {
"babel-eslint": "^10.0.3",
Expand Down
5 changes: 4 additions & 1 deletion packages/oidc-middleware/src/logout.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ const makeTokenRevoker = ({ issuer, client_id, client_secret, errorHandler }) =>
body: querystring.stringify({token, token_type_hint: token_hint}),
})
// eslint-disable-next-line promise/no-nesting
.then( r => r.ok ? r : r.text().then(message => Promise.reject(new OIDCMiddlewareError('revokeError', message)) ))
// .then( r => r.ok ? r : r.text().then(message => Promise.reject(new OIDCMiddlewareError('revokeError', message)) ))
.then( r => r.ok ? r : r.text().then((message) => {
throw new OIDCMiddlewareError('revokeError', message);
}))
.catch( errorHandler ) // catch and emit - this promise chain can never fail
};
};
Expand Down
17 changes: 10 additions & 7 deletions packages/oidc-middleware/test/e2e/harness/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module.exports = class DemoServer {
const app = express();
this.app = app;
app.use(session({
secret: uuid(), // this will invalidate all sessions on each restart
secret: uuid.v4(), // this will invalidate all sessions on each restart
resave: true,
saveUninitialized: false
}));
Expand Down Expand Up @@ -75,13 +75,16 @@ module.exports = class DemoServer {
stop() {
console.log('Server shutting down');
return new Promise((resolve, reject) => {
this.httpServer.destroy((err) => {
console.log('Server destroyed')
if (err) {
return reject(err);
}
if (this.httpServer) {
this.httpServer.destroy((err) => {
console.log('Server destroyed')
if (err) {
return reject(err);
}
return resolve();
});
} else
return resolve();
});
});
}
}
Expand Down
Loading