Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AuthFoundationDefaults configurable by other SDKs #323

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Make AuthFoundationDefaults configurable by other SDKs #323

merged 3 commits into from
Feb 5, 2025

Conversation

rajdeepnanua-okta
Copy link
Contributor

@rajdeepnanua-okta rajdeepnanua-okta commented Jan 30, 2025 •
edited
Loading

This PR does the following:

  1. Makes AuthFoundationDefaults configurable by other SDKs (without the risk of crashing the app)
  2. Update libraries to the latest versions available. The only exception being spotless and jackson, which runs into issues with newer versions
  3. Add snyk scan. This is mostly the same implementation as in okta-devices-kotlin.

@rajdeepnanua-okta rajdeepnanua-okta force-pushed the idx_configurable_defaults branch from c2f1bb2 to bf690f7 Compare January 30, 2025 20:42
mikenachbaur-okta
mikenachbaur-okta reviewed Jan 30, 2025
View reviewed changes
scripts/dependency_scan.sh
#####
## Build Environment Setup
#####
java17_0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sets up java 17 in our internal build system

@rajdeepnanua-okta rajdeepnanua-okta force-pushed the idx_configurable_defaults branch 3 times, most recently from e7f62c7 to 762cbf2 Compare January 31, 2025 20:26
@rajdeepnanua-okta rajdeepnanua-okta force-pushed the idx_configurable_defaults branch from 762cbf2 to 8e994d4 Compare February 1, 2025 03:55
@rajdeepnanua-okta rajdeepnanua-okta force-pushed the idx_configurable_defaults branch from 8e994d4 to 884ef31 Compare February 1, 2025 04:45
@rajdeepnanua-okta rajdeepnanua-okta merged commit 4fea239 into master Feb 5, 2025
3 of 4 checks passed
@rajdeepnanua-okta rajdeepnanua-okta deleted the idx_configurable_defaults branch February 5, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredperreault-okta jaredperreault-okta jaredperreault-okta approved these changes

@mikenachbaur-okta mikenachbaur-okta mikenachbaur-okta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajdeepnanua-okta @mikenachbaur-okta @jaredperreault-okta