ci: execute eyes-storybook-in-ci-only #2473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-849447
Summary
A CI and install-time change that removes the dependency of
@applitools/eyes-storybook
as an installable package and instead makes it a CI-runtime executable.This addresses the vuln ticket linked above to prevent
puppeteer
(a dependency ofeyes-storybook
) from running itspostinstall
script whenever the dependencies of the odyssey repo are installed.More info here: https://socket.dev/npm/package/puppeteer/alerts/23.5.1?alert_name=installScripts
The fix here is to execute
eyes-storybook
as a runtime executable only when needed in CI, by having yarn download and executeeyes-storybook
when the scriptci:visualRegressionTest
is invoked.The change also impacts the invocation of
dev:visualRegressionTest
locally on dev machines and there should be no change in how it runs.Testing & Screenshots