Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: execute eyes-storybook-in-ci-only #2473

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

chrispulsinelli-okta
Copy link
Contributor

OKTA-849447

Summary

A CI and install-time change that removes the dependency of @applitools/eyes-storybook as an installable package and instead makes it a CI-runtime executable.

This addresses the vuln ticket linked above to prevent puppeteer (a dependency of eyes-storybook) from running its postinstall script whenever the dependencies of the odyssey repo are installed.

More info here: https://socket.dev/npm/package/puppeteer/alerts/23.5.1?alert_name=installScripts

The fix here is to execute eyes-storybook as a runtime executable only when needed in CI, by having yarn download and execute eyes-storybook when the script ci:visualRegressionTest is invoked.

The change also impacts the invocation of dev:visualRegressionTest locally on dev machines and there should be no change in how it runs.

Testing & Screenshots

  • I have confirmed this change with my designer and the Odyssey Design Team.

@chrispulsinelli-okta chrispulsinelli-okta requested a review from a team as a code owner January 20, 2025 15:47
@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 43524da into main Jan 27, 2025
1 check passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the OKTA-849447-fix-op-risk-puppeteer branch January 27, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants