fix/rfc(cache): if previously not found, still look up icon #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the case where an icon was previously looked up, not found, and now exists (i.e. when an application was installed)
ryanabx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: pop-os/libcosmic#402
This fixes the case where an icon was previously looked up, not found, and now exists (i.e. when an application was installed)
This may not be desired behavior, it may be intended for icons that weren't found on initial cache lookup to be unreachable, hence why this is a fix/rfc.
An example in COSMIC for how the previous behavior can negatively affect applications on a taskbar:
The photo above shows how Visual Studio Code has a valid desktop entry and icon, but since the icon was installed shortly after the desktop entry, the icon is not accessible if we use the cache, since it looked it up and didn't find it at first.