Skip to content

Commit

Permalink
Fix subject text
Browse files Browse the repository at this point in the history
  • Loading branch information
noeddl authored and pajowu committed Jan 22, 2025
1 parent dc61554 commit bda7767
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion froide/foirequest/notifications.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def send_update(notifications: List[Notification], user):

count = len(request_list)
subject = ngettext_lazy(
"Update on one of your request", "Update on %(count)s of your requests", count
"Update on one of your requests", "Update on %(count)s of your requests", count
) % {"count": count}

update_requester_email.send(
Expand Down
6 changes: 3 additions & 3 deletions froide/foirequest/tests/test_misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def test_requester_batch_update(self):
)
batch_update_requester(start=start, end=end)
self.assertEqual(len(mail.outbox), 1)
self.assertIn("Update on one of your request", mail.outbox[0].subject)
self.assertIn("Update on one of your requests", mail.outbox[0].subject)


class SendUpdateTest(TestCase):
Expand Down Expand Up @@ -203,7 +203,7 @@ def test_includes_requests_with_only_non_requester_comments(self):
assert len(request_list) == 1
assert request_list[0]["request"] == self.request1a
assert request_list[0]["events"] == ["Comment 2"]
assert mock_send.call_args[1]["subject"] == "Update on one of your request"
assert mock_send.call_args[1]["subject"] == "Update on one of your requests"

def test_includes_requests_with_both_requester_and_non_requester_comments(self):
notifications = [self.comment_request1a_user1, self.comment_request1a_user2]
Expand All @@ -220,7 +220,7 @@ def test_includes_requests_with_both_requester_and_non_requester_comments(self):
assert len(request_list) == 1
assert request_list[0]["request"] == self.request1a
assert request_list[0]["events"] == ["Comment 1", "Comment 2"]
assert mock_send.call_args[1]["subject"] == "Update on one of your request"
assert mock_send.call_args[1]["subject"] == "Update on one of your requests"

def test_includes_multiple_requests_with_comments_from_multiple_users(self):
notifications = [
Expand Down
2 changes: 1 addition & 1 deletion froide/locale/de/LC_MESSAGES/django.po
Original file line number Diff line number Diff line change
Expand Up @@ -4137,7 +4137,7 @@ msgstr "Nutzer:in wurde eine E-Mail gesendet."

#: froide/foirequest/notifications.py
#, python-format
msgid "Update on one of your request"
msgid "Update on one of your requests"
msgid_plural "Update on %(count)s of your requests"
msgstr[0] "Neues bei einer Ihrer Anfragen"
msgstr[1] "Neues bei %(count)s Ihrer Anfragen"
Expand Down

0 comments on commit bda7767

Please sign in to comment.