Complete

okeyiii · Jul 17, 2023 · c9a2626 · c9a2626
1 parent 0f71af7
commit c9a2626
Show file tree

Hide file tree

Showing 9 changed files with 33 additions and 16 deletions.
diff --git a/changelog_entry.yaml b/changelog_entry.yaml
@@ -0,0 +1,5 @@
+- bump: minor
+  changes:
+    added:
+    - Nova Scotia Basic personal amount.
+
diff --git a/...eters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/additional_amount.yaml b/...eters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/additional_amount.yaml
@@ -8,4 +8,4 @@ metadata:
   - title: Nova Scotia Basic Personal Amount
     href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
   - title: Nova Scotia Basic Personal Amount
-    href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
+    href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
diff --git a/...ameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/applicable_rate.yaml b/...ameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/applicable_rate.yaml
@@ -8,4 +8,4 @@ metadata:
   - title: Nova Scotia Basic Personal Amount
     href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
   - title: Nova Scotia Basic Personal Amount
-    href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
+    href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
diff --git a/...parameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/basic_amount.yaml b/...parameters/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/basic_amount.yaml
@@ -8,4 +8,4 @@ metadata:
   - title: Nova Scotia Basic Personal Amount
     href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
   - title: Nova Scotia Basic Personal Amount
-    href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
+    href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
diff --git a/...gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/higher_income_threshold.yaml b/...gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/higher_income_threshold.yaml
@@ -8,4 +8,4 @@ metadata:
   - title: Nova Scotia Basic Personal Amount
     href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
   - title: Nova Scotia Basic Personal Amount
-    href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
+    href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
diff --git a/.../gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/lower_income_threshold.yaml b/.../gov/provinces/ns/tax/income/credits/ns_basic_personal_amount/lower_income_threshold.yaml
@@ -8,4 +8,4 @@ metadata:
   - title: Nova Scotia Basic Personal Amount
     href: https://hr.acadiau.ca/files/sites/hr/Payroll/Pensions%20&%20Benefits/NS_TD1_2022.pdf
   - title: Nova Scotia Basic Personal Amount
-    href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
+    href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/5003-d/5003-d-22e.pdf
diff --git a/policyengine_canada/tests/gov/provinces/ab/tax/income/credits/pension/ab_pension_credit.yaml b/policyengine_canada/tests/gov/provinces/ab/tax/income/credits/pension/ab_pension_credit.yaml
@@ -20,4 +20,4 @@
     pension_and_savings_plan_income: 0
     province_code: AB
   output:
-    ab_pension_credit: 0
+    ab_pension_credit: 0
diff --git a/policyengine_canada/tests/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount.yaml b/policyengine_canada/tests/gov/provinces/ns/tax/income/credits/ns_basic_personal_amount.yaml
@@ -28,4 +28,4 @@
     province_code: NS
     total_individual_pre_tax_income: 76_000
   output:
-    ns_basic_personal_credits: 8_481
+    ns_basic_personal_credits: 8_481
diff --git a/...yengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_basic_personal_credits.py b/...yengine_canada/variables/gov/provinces/ns/tax/income/credits/ns_basic_personal_credits.py
@@ -9,13 +9,25 @@ class ns_basic_personal_credits(Variable):
     defined_for = ProvinceCode.NS
 
     def formula(person, period, parameters):
-        p = parameters(period).gov.provinces.ns.tax.income.credits.ns_basic_personal_amount
-        taxable_income = person("total_individual_pre_tax_income",period)
+        p = parameters(
+            period
+        ).gov.provinces.ns.tax.income.credits.ns_basic_personal_amount
+        taxable_income = person("total_individual_pre_tax_income", period)
 
-        return select([taxable_income <= p.lower_income_threshold, 
-                p.lower_income_threshold < taxable_income < p.higher_income_threshold,
-                taxable_income >= p.higher_income_threshold],
-
-               [p.additional_amount + p.basic_amount,
-                p.basic_amount + 3000 - p.applicable_rate*(taxable_income - p.lower_income_threshold),
-                p.basic_amount])
+        return select(
+            [
+                taxable_income <= p.lower_income_threshold,
+                p.lower_income_threshold
+                < taxable_income
+                < p.higher_income_threshold,
+                taxable_income >= p.higher_income_threshold,
+            ],
+            [
+                p.additional_amount + p.basic_amount,
+                p.basic_amount
+                + 3000
+                - p.applicable_rate
+                * (taxable_income - p.lower_income_threshold),
+                p.basic_amount,
+            ],
+        )