prov/efa: Use srx lock from domain directly #9991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, efa_rdm_cq_readfrom access srx_lock via util_domain->srx->peer_srx.ep_fid.fid.context. However, srx is destroyed during ep close and may not be accessible if a cq read is called after ep close. This patch fixes this issue by accessing the srx lock via efa_domain directly, as the lock is created by efa domain and cannot be destroyed before domain close. Same issue applies to efa cntr. Signed-off-by: Shi Jin <[email protected]>
wenduwan
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, efa_rdm_cq_readfrom access srx_lock
via util_domain->srx->peer_srx.ep_fid.fid.context. However, srx is destroyed during ep close and may not be accessible if a cq read is called after ep close. This patch fixes this issue by accessing the srx lock via efa_domain directly, as the lock is created by efa domain and cannot be destroyed before domain close.
Same issue applies to efa cntr.