fabtests: Add backlog > 0 to listen call #9963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the listen() call has a 0 value for backlog. This causes syn (synchronize) flooding on port 3000. Port 3000 is used by fabtests for OOO (out of bounds) exchanges. This call needs to have a non-zero positive value for backlog to prevent this flooding. Setting the backlog is necessary so that it is changeable by the user and not hidden values that users must set at the kernel level. The kernel variables are called net.ipv4.tcp_max_syn_backlog, and net.core.somaxconn to fix the issue instead. However, it is encouraged that a user make sure all of these values are set appropriately as well as using an adequate size for backlog in the listen call. Signed-off-by: Zach Dworkin <[email protected]>
j-xiong
approved these changes
Apr 1, 2024
|
bot:aws:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the listen() call has a 0 value for backlog. This causes syn (synchronize) flooding on port 3000. Port 3000 is used by fabtests for OOO (out of bounds) exchanges.
This call needs to have a non-zero positive value for backlog to prevent this flooding. Setting the backlog is necessary so that it is changeable by the user and not hidden values that users must set at the kernel level. The kernel variables are called net.ipv4.tcp_max_syn_backlog, and net.core.somaxconn to fix the issue instead. However, it is encouraged that a user make sure all of these values are set appropriately as well as using an adequate size for backlog in the listen call.