prov/sockets: Fix coveritylocking issues #9927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's more useful if the commit header describe the problem/fix rather than a reference to a coverity report |
sydidelot
reviewed
Mar 22, 2024
prov/sockets/src/sock_wait.c
Outdated
| return 1; | ||
| } |
There was a problem hiding this comment.
There is a pthread_mutex_lock(&cq->lock); missing here, before the break.
There was a problem hiding this comment.
fixed in latest push, thanks!
Fix coverity 407557's missing lock The cq error path should be considerably refactored. This lock is needed for the current implementation. Ideally we won't want this lock or check because it is optimizing the error case and slowing down the actual use case. Signed-off-by: Zach Dworkin <[email protected]>
Add lock around err_flag like other places in this file. Signed-off-by: Zach Dworkin <[email protected]>
Fix coverity missing lock Signed-off-by: Zach Dworkin <[email protected]>
Fix coverity missing lock Signed-off-by: Zach Dworkin <[email protected]>
|
bot:aws:retest |
j-xiong
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.