fabtests: Fix coverity issues 414806, 414801, 414809 #9889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-xiong
reviewed
Mar 15, 2024
j-xiong
approved these changes
Mar 15, 2024
Correctly cleanup ctrl_f pointer. Signed-off-by: Zach Dworkin <[email protected]>
Don't use rand() because it has known exploits Fix coverity 414801 and 414809 Signed-off-by: Zach Dworkin <[email protected]>
|
Ignoring the known CI issue that has been fixed in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
414806: Fix resouce leak
414801, 414809: Replace rand() use with custom get_random_data() that does the same thing but uses /dev/urandom to get the data.