prov/efa: Move struct efa_ep_addr to efa_base_ep #10702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want bigger changes than this, closing. |
|
reopening, I think I do actually want this... baby steps |
shijin-aws
reviewed
Jan 15, 2025
prov/efa/src/efa_base_ep.h
Outdated
| @@ -27,6 +27,19 @@ struct efa_qp { | |||
| uint32_t qkey; | |||
| }; | |||
|
|
|||
| /* raw address format. (section 1.4) */ | |||
There was a problem hiding this comment.
since you moved the code, you need to update the comment as now reader doesn't related section 1.4 to the protocol doc.
There was a problem hiding this comment.
removed the outdated comment.
a-szegel
force-pushed
the
move-efa-ep-addr-to-base-ep
branch
from
4d46f35 to
c52b718
Compare
shijin-aws
approved these changes
Jan 15, 2025
struct efa_ep_addr is used in both the DGRAM and RDM providers, so the structure definition should be in a common file, and not an RDM only file. Signed-off-by: Seth Zegelstein <[email protected]>
a-szegel
force-pushed
the
move-efa-ep-addr-to-base-ep
branch
from
c52b718 to
4e47263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
struct efa_ep_addr is used in both the DGRAM and RDM providers, so the structure definition should be in a common file, and not an RDM only file.