prov/tcp: Fix race in writing to xnet_ep_fi_ops #10590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
Can you please update the commit message to: "prov/tcp: Fix race ...", and also describe the race in the commit message? |
xnet_endpoint updates the static global variable: xnet_ep_fi_ops. This naturally causes a data race. This PR eliminates the write. Signed-off-by: Dariusz Sciebura <[email protected]>
dsciebu
force-pushed
the
dariuszs/xnet
branch
from
923365a to
a9755ea
Compare
|
@shefty done! |
shefty
approved these changes
Dec 5, 2024
|
Hey, will you merge my patch? |
dsciebu
changed the title
|
Merged, as this should go into the next release. It should probably be cherry picked into the stable release(s) as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xnet_endpoint updates the static global variable: xnet_ep_fi_ops.
This naturally causes a data race. This PR eliminates the write.
Signed-off-by: Dariusz Sciebura [email protected]