[IMP] IndirectReference.model_filter #195
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
upgradeci retry with always only base |
KangOl
force-pushed
the
master-IR-model_filter-company_dependent_comodel-chs
branch
from
fbd0600 to
28820de
Compare
aj-fuentes
reviewed
Jan 17, 2025
src/util/indirect_references.py
Outdated
| @@ -19,11 +19,15 @@ def model_filter(self, prefix="", placeholder="%s"): | |||
| else: | |||
| column = self.res_model | |||
|
|
|||
| if column is None: | |||
| # `model` is not set when `company_dependent_comodel` is. | |||
| return "(false and {} IS NULL)".format(placeholder) | |||
There was a problem hiding this comment.
Suggested change
| return "(false and {} IS NULL)".format(placeholder) | |
| return "(false AND {} IS NULL)".format(placeholder) |
Handle `company_dependent_comodel` in the `model_filter` method. When it's set, there is no model, so return `false` (sql boolean).
Correct default values. `company_dependent_comodel` should also have a default. (Actually, as the defaults are pushed from the end, it's `res_id` that didn't have any).
KangOl
force-pushed
the
master-IR-model_filter-company_dependent_comodel-chs
branch
from
28820de to
afc1bcd
Compare
|
@robodoo rebase-ff r+ |
|
Merge method set to rebase and fast-forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
company_dependent_comodelin themodel_filtermethod. When it's set, there is no model, so returnfalse(sql boolean).