[FIX] util/report: improve report categories for better precision #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm not sure we need this. The current order reflects the order the info was logged. Do we really get tickets related to this? I don't see anything related to order in the linked ticket. The description here is a bit misleading also, you are not "refining" anything, you are just sorting the categories lexicographically. I'd suggest if you do so to just sort the data that's passed in |
bda-odoo
force-pushed
the
master-improve-report-category-sorted-bda
branch
from
7198cf9 to
aed4a05
Compare
@aj-fuentes Thank you for your review. The suggested changes have been implemented. |
|
upgradeci retry with always only base |
bda-odoo
force-pushed
the
master-improve-report-category-sorted-bda
branch
from
aed4a05 to
3308721
Compare
Summary: This update improves the handling of report categories in the utility module to ensure they are more precise and well-organized. Reason for the Change: It was observed that the report categories were not sorted lexicographically in order, leading to a lack of precision and organization. To address this, the categories have been sorted lexicographically to enhance their clarity and structure. opw-4424140
bda-odoo
force-pushed
the
master-improve-report-category-sorted-bda
branch
from
3308721 to
455c6e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This update improves the handling of report categories in the utility module to ensure they are more precise and well-organized.
Reason for the Change:
It was observed that the report categories were not sorted lexicographically in order, leading to a lack of precision and organization. To address this, the categories have been sorted lexicographically to enhance their clarity and structure.
opw-4424140
here is the attached visual capture
After this patch