[ADD] estate: add real estate module #224

dija-odoo · 2025-01-17T02:17:23Z

Create a real estate module module for training purpose

For learning purposes, I added an Estate module to the app, which includes views and models for managing new properties, property types, tags, and offers.

…ethods. For learning purpose, tried implementing computed fields, Dependencies.. Also created button of type object and learned difference of private and public methods.

For learning purposes, tried to implement different types of methods & buttons. Learned different ways to manipulating views by using widgets, attributes & more

Learned different types of Inheritance in Odoo including Model & View Inheritance and then further implemented it. Created estate_account module to link invoicing to invoice sold properties. For learning purposes, Implemented kanban view and related changes.

Completed chapters of Server framework 101 for learning purposes, also tried to follow coding guidelines. Implemented adding demo data.

For learning purposes, completed Build PDF reports. Implemented templates and also template inheritance.

Changes made in a way to restrict unauthorized access to property data, limits agent interaction with property types and tags, and uses security bypasses for selling property.

For learning purpose, added wizard for making offer for selected multiple properties and also handling case where offers can not be applied to all properties which will show error in notification and skip adding offers to properties generating errors.

Added controllers for estate module to view available properties on the website in grid format. Clicking on the property opens detailed view of the property.

robodoo · 2025-01-17T02:17:26Z

Added images to demo data for card view of properties on the website. configured menu item named properties in the navbar.

adsh-odoo

Hello @dija-odoo
Some comments/suggestions
Thanks

adsh-odoo · 2025-01-17T09:55:30Z

estate/controllers/main.py

+    def properties(self, page=1):
+        items_per_page = 6
+        Property = request.env['estate.property']
+        total_properties = Property.search_count([  


we need to use sudo for public user here.

adsh-odoo · 2025-01-17T10:11:44Z

estate/models/estate_property.py

+                selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')],
+                string='Garden Orientation') 
+    active=fields.Boolean(default=True)
+    # last_seen = fields.Datetime("Last Seen", default=fields.Datetime.now)


avoid pushing commented code

adsh-odoo · 2025-01-17T10:16:19Z

estate/models/estate_property.py

+    def print_quotation(self):
+        return self.env.ref('estate.action_report_estate_property_sold').report_action(self)


we can remove this one as we are printing reports from action menu

adsh-odoo · 2025-01-17T10:18:31Z

estate/models/estate_property.py

+            'view_mode': 'form',
+            'res_model': 'estate.property.make.bulk.offer',
+            'context': {
+                'default_property_id': self.ids,


we can get the selected properties using self.context.get('active_ids') so there is no need for passing the context explicitly here.

adsh-odoo · 2025-01-17T10:22:53Z

estate/security/security.xml

+        <field name="model_id" ref="estate.model_estate_property"/>
+        <field name="perm_read" eval="True"/>
+        <field name="groups" eval="[Command.link(ref('estate.estate_group_manager'))]"/>
+        <field name="domain_force">[]</field>


Suggested change

<field name="domain_force">[]</field>

<field name="domain_force">[(1, '=', 1)]</field>

adsh-odoo · 2025-01-17T10:33:06Z

estate/models/estate_property.py

+        for record in self:
+            if record.status_button != 'sold':
+                record.status_button='cancelled'
+                record.state='cancelled'


same here as above

adsh-odoo · 2025-01-17T10:34:10Z

estate/models/estate_property_offer.py

+        return True
+
+
+    def cross_refuse(self):


Suggested change

def cross_refuse(self):

def action_refuse(self):

Same for above

adsh-odoo · 2025-01-17T10:37:35Z

estate/wizard/estate_property_make_bulk_offer.py

+    _name = 'estate.property.make.bulk.offer'
+    _description = 'Make Bulf Offer for Properties at once'
+
+    property_id = fields.Many2many('estate.property', string='Property', required=True, ondelete="cascade")


no need for this field when we use the active_ids from context

adsh-odoo · 2025-01-17T10:38:31Z

estate/wizard/estate_property_make_bulk_offer.py

+    def make_offers(self):
+        property_failed = []
+        for property in self.property_id:
+            try:
+                self.env['estate.property.offer'].create({
+                    'price': self.price,
+                    'property_id': property.id,
+                    'partner_id': self.partner_id.id,
+                    'validity': self.validity
+                })


adapt here also with new implementation using active_ids

adsh-odoo · 2025-01-17T10:48:31Z

estate/models/estate_property.py

+from datetime import datetime
+from odoo import models,fields,api,_
+from dateutil.relativedelta import relativedelta
+from odoo.exceptions import UserError


Suggested change

from datetime import datetime

from odoo import models,fields,api,_

from dateutil.relativedelta import relativedelta

from odoo.exceptions import UserError

from datetime import datetime

from dateutil.relativedelta import relativedelta

from odoo import api, fields, models

from odoo.exceptions import UserError

Generally we first make external imports and then we import from odoo in alphabetical order.
Need to adapt in all files

dija-odoo added 9 commits January 2, 2025 10:42

[ADD] estate_property_module: added primary views and models.

f552a81

For learning purposes, I added an Estate module to the app, which includes views and models for managing new properties, property types, tags, and offers.

[ADD] estate_property: added computed fields and tried implementing m…

fdf3a9e

…ethods. For learning purpose, tried implementing computed fields, Dependencies.. Also created button of type object and learned difference of private and public methods.

[IMP] estate_property: added chapters of constraints and UI parts

6d7ff4f

For learning purposes, tried to implement different types of methods & buttons. Learned different ways to manipulating views by using widgets, attributes & more

[IMP] estate_property: completed Server framework 101 and demo data

bc9abc4

Completed chapters of Server framework 101 for learning purposes, also tried to follow coding guidelines. Implemented adding demo data.

[IMP] estate_property: added build pdf reports

0394b6e

For learning purposes, completed Build PDF reports. Implemented templates and also template inheritance.

[IMP] estate: chapter restrict access to data completed

2211552

Changes made in a way to restrict unauthorized access to property data, limits agent interaction with property types and tags, and uses security bypasses for selling property.

[IMP] estate: added controller for properties

284dcb3

Added controllers for estate module to view available properties on the website in grid format. Clicking on the property opens detailed view of the property.

[IMP] estate: updated controller-added property as menu-item

055f4d5

Added images to demo data for card view of properties on the website. configured menu item named properties in the navbar.

dija-odoo force-pushed the 18.0-training-dija branch from 3b3e869 to 055f4d5 Compare January 17, 2025 05:40

adsh-odoo reviewed Jan 17, 2025

View reviewed changes

[IMP] estate: changes after PR review

09c61b9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] estate: add real estate module #224

[ADD] estate: add real estate module #224

dija-odoo commented Jan 17, 2025

robodoo commented Jan 17, 2025

adsh-odoo left a comment

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

		def print_quotation(self):
		return self.env.ref('estate.action_report_estate_property_sold').report_action(self)

	<field name="domain_force">[]</field>
	<field name="domain_force">[(1, '=', 1)]</field>

[ADD] estate: add real estate module #224

Are you sure you want to change the base?

[ADD] estate: add real estate module #224

Conversation

dija-odoo commented Jan 17, 2025

robodoo commented Jan 17, 2025

adsh-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment