[ADD] estate: add real estate module #221

nipl-odoo · 2025-01-16T05:34:51Z

Create real estate module for training purposes.

Added basic models for property, property type, property tags and property offer Also made basic views needed for proper representation of data. Right now all base user have access of data. Note: Right now all model views and records are there in single xml.

Finished chapter 7,8 and 9 with all features and exercise mentioned. Business Logic SQL constrains Validations

Finished chapter 10 and half 11 (Uptill Attributes and options) Added python constrains and UI improvements

upto chapter 11 and 12 half note: I am still not able to reference new field from inherited user model

finished chapter 12 inheritance is working fine we can see real estate properties assigned to salesperson in users tab.

removed unnecessory model access given on inherited model

Finished all chapters of server framework 101 added some of my own ideas in kanban view. and guess what it's looking good ;)

Added demo data in estate module, checked all possibilities of demo data. Only one problem i noticed is that we can not use the same database twice while working with demo data because it overwrites demo data every time so states of properties are jumbled.

Added pdf reports feature so that user can download pdf reports based on property or salesman. Finised build pdf reports module.

Fixed offer action button bug. I was unable to access Many2One fiend in view. So i made an related field in offer model to make sure accept and reject buttons are disappeared whenever property goes into offer_Accepted state.

Added ACL so that all users can not access all properties. Also restricted access of agents to see other agent's property. Also bypassed marking property sold by agents. (But only if current user has write access on estate property)

Added feature to view property based on company selected. Visibility of companies is limited to manager only. Agent can only see information in his/her company only. Also added wizard for creating bulk offer on selected properties.

Fixed bug while creating bulk offer when one of the property throws validation error. Also added properties on website through controller. Pagination is still remaining.

Corrected incorrectly working pager and property details page where user can see details of property whose state is new, offer_received or offer_accepted. Also users can not see archived properties. Finished all the python training given by our mentor.

robodoo · 2025-01-16T05:34:53Z

adsh-odoo

Hello @nipl-odoo
Some comments/suggestions
I can also see some extra blank lines remove them also.
Thanks!!

adsh-odoo · 2025-01-17T07:13:39Z

estate/controllers/estate_website.py

+    @http.route(
+        ["/properties", "/properties/page/<int:page>"],
+        type="http",
+        auth="user",


we can use auth="public" here

adsh-odoo · 2025-01-17T07:33:00Z

estate/models/estate_property.py

+            "context": {
+                "default_property_ids": self.ids,
+            },


it will not be needed we can get the selected property by self.env.context.get('active_ids')

adsh-odoo · 2025-01-17T07:34:57Z

estate/models/estate_property_type.py

+    _sql_constraints = [
+        ("name_uniq", "unique(name)", "Type must be unique"),
+    ]


we write constraints after field definition

adsh-odoo · 2025-01-17T07:39:04Z

estate/security/estate_security.xml

+        <field name="name">Estate Manager rules for all properties</field>
+        <field name="model_id" ref="estate.model_estate_property"/>
+        <field name="groups" eval="[Command.link(ref('estate.estate_group_manager'))]" />
+        <field name="domain_force">[]</field>


Suggested change

<field name="domain_force">[]</field>

<field name="domain_force">[(1, '=', 1)]</field>

adsh-odoo · 2025-01-17T07:42:45Z

estate/views/estate_property_views.xml

+                        <h1>
+                            <field name="name" label="Property Name" placeholder="Property Name" />
+                        </h1>
+                        <field name="image" widget="image" options="{'size': [150, 150]}"/>


Generally, we put the image in the right side of the sheet

adsh-odoo · 2025-01-17T07:49:46Z

estate_account/__manifest__.py

+    "website": "https://www.odoo.com",
+    "category": "Tutorials/Estate_Account",
+    "version": "0.1",
+    "application": True,


it's bridge module so we can remove the application true here.

adsh-odoo · 2025-01-17T07:55:59Z

estate/wizard/estate_property_make_offer.py

+    _name = "estate.property.make.offer"
+    _description = "Estate Property Make Offer Wizard"
+
+    property_ids = fields.Many2many("estate.property", string="Properties")


I think there is no need to link this wizard with estate property

adsh-odoo · 2025-01-17T07:59:13Z

estate/wizard/estate_property_make_offer.py

+        failed_properties = []
+        for property in self.property_ids:
+            try:
+                self.env["estate.property.offer"].create(
+                    {
+                        "price": self.offer_price,
+                        "property_id": property.id,
+                        "partner_id": self.partner_id.id,
+                        "validity": self.offer_validity,
+                    }
+                )
+            except Exception:
+                failed_properties.append(property.name)
+        if failed_properties:
+            return {
+                "type": "ir.actions.client",
+                "tag": "display_notification",
+                "params": {
+                    "message": "Failed to create offers for the following properties: "
+                    + ", ".join(failed_properties),
+                    "type": "danger",
+                    "next": {"type": "ir.actions.act_window_close"},
+                },
+            }


we can simplify this by taking the property_ids from context (from my previous comment) and creating offer directly inside them Let me know what you think.
Can you give it a try?

adsh-odoo · 2025-01-17T09:16:00Z

estate/models/estate_property.py

+from odoo import models, fields, api
+from odoo.exceptions import UserError
+from datetime import datetime
+from dateutil.relativedelta import relativedelta


Suggested change

from odoo import models, fields, api

from odoo.exceptions import UserError

from datetime import datetime

from dateutil.relativedelta import relativedelta

from datetime import datetime

from dateutil.relativedelta import relativedelta

from odoo import api, fields, models

from odoo.exceptions import UserError

Generally we first make external imports and then we import from odoo in alphabetical order.
Need to adapt in all files

Refactored code according to common coding guidelines followed here.

nipl-odoo added 15 commits January 2, 2025 10:18

[IMP] estate: added Business logic in estate module buttons

fa90e2e

Finished chapter 7,8 and 9 with all features and exercise mentioned. Business Logic SQL constrains Validations

[IMP] estate: Added Proper validation in all actions and UI

97fb4f9

Finished chapter 10 and half 11 (Uptill Attributes and options) Added python constrains and UI improvements

[IMP] estate: added ui bug fixes and inheritance

2574d72

upto chapter 11 and 12 half note: I am still not able to reference new field from inherited user model

[IMP] estate: finished chapter 12

e984273

finished chapter 12 inheritance is working fine we can see real estate properties assigned to salesperson in users tab.

[IMP] estate: removed unnecessory access from csv

92c5207

removed unnecessory model access given on inherited model

[IMP] estate: finished server framework 101 tutorials

62402fd

Finished all chapters of server framework 101 added some of my own ideas in kanban view. and guess what it's looking good ;)

[IMP] estate: added demo data

9542868

Added demo data in estate module, checked all possibilities of demo data. Only one problem i noticed is that we can not use the same database twice while working with demo data because it overwrites demo data every time so states of properties are jumbled.

[ADD] estate: added pdf reports

743b5a0

Added pdf reports feature so that user can download pdf reports based on property or salesman. Finised build pdf reports module.

[IMP] estate: fixed offer action button bugs

6da58e7

Fixed offer action button bug. I was unable to access Many2One fiend in view. So i made an related field in offer model to make sure accept and reject buttons are disappeared whenever property goes into offer_Accepted state.

[IMP] estate,estate_account: added ACL

1d89221

Added ACL so that all users can not access all properties. Also restricted access of agents to see other agent's property. Also bypassed marking property sold by agents. (But only if current user has write access on estate property)

[IMP] estate: fixed bulk offer bug and added controller

90904ed

Fixed bug while creating bulk offer when one of the property throws validation error. Also added properties on website through controller. Pagination is still remaining.

[IMP] estate: minor optimization

4907827

nipl-odoo force-pushed the 18.0-training-nipl branch 2 times, most recently from 5a0e7fa to 9691a9b Compare January 16, 2025 06:13

[IMP] estate,estate_acoount: minor changes for github error

13455c5

nipl-odoo force-pushed the 18.0-training-nipl branch from 9691a9b to 13455c5 Compare January 16, 2025 06:17

[IMP] estate: added images in demo data

28a21db

nipl-odoo force-pushed the 18.0-training-nipl branch from 83553fd to 28a21db Compare January 16, 2025 07:06

[IMP] estate: add nav item on estate installation

1261bf9

adsh-odoo reviewed Jan 17, 2025

View reviewed changes

nipl-odoo force-pushed the 18.0-training-nipl branch from 3bbd00a to 1ad40ed Compare January 17, 2025 10:18

[IMP] estate: minor PR changes

17d0010

Refactored code according to common coding guidelines followed here.

nipl-odoo force-pushed the 18.0-training-nipl branch from 1ad40ed to 17d0010 Compare January 17, 2025 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] estate: add real estate module #221

[ADD] estate: add real estate module #221

nipl-odoo commented Jan 16, 2025

robodoo commented Jan 16, 2025

adsh-odoo left a comment

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

adsh-odoo Jan 17, 2025

	<field name="domain_force">[]</field>
	<field name="domain_force">[(1, '=', 1)]</field>

[ADD] estate: add real estate module #221

Are you sure you want to change the base?

[ADD] estate: add real estate module #221

Conversation

nipl-odoo commented Jan 16, 2025

robodoo commented Jan 16, 2025

adsh-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment