Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] estate : added the sprinkles. #214

Draft
wants to merge 16 commits into
base: 18.0
Choose a base branch
from

Conversation

shai-odoo
Copy link

No description provided.

it contain information  related to  model. It is based on estate application.
It covers different chapters of real estate.
It has various updated features.
It has various views  with many to one and many to many fields.
It has information related to compute fields.
@robodoo
Copy link

robodoo commented Dec 17, 2024

Pull request status dashboard

Copy link

@aktr-odoo aktr-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, can you please make the changes according to the comments?
Thanks!

Comment on lines 2 to 4



Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@@ -0,0 +1,24 @@
{
'name': 'estate',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra lines

Comment on lines 1 to 6
from odoo import models, fields
from datetime import timedelta, date
from odoo import models, fields, api
from odoo.exceptions import UserError
from odoo.exceptions import ValidationError
from odoo.tools.float_utils import float_compare, float_is_zero

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove duplicated code and use alphabetical order

Comment on lines 2 to 4
from . import estate_property_type
from . import estate_property_tags
from . import estate_property_offer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arrange in alphabetical order

Comment on lines 15 to 24
'data': [
'security/ir.model.access.csv',
'views/estate_property_views.xml',
'views/estate_property_type_views.xml',
'views/estate_property_tags_views.xml',
'views/estate_property_offer_views.xml',
'views/estate_menus.xml'
],

}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use proper format

<sheet>
<group>
<field name="name"/>
<field name="tag_ids" widget="many2many_tags" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why tag_ids

Comment on lines 29 to 30
<field name="tag_ids"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Comment on lines 48 to 50
<br />
<br />
<br />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why <br/>

<field name="selling_price"/>
</group>
<group>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra space

Comment on lines 62 to 63


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra space

I have added demo data and started working on PDF reports.
Given some permission to the managers and given some restriction to the agents.
Task related to wizards are completed.
Task related to chatter and action helper are completed.
Added multiple warranty on products .
created invoice and sale order PDF.
Added views and models.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants