ahta - Server framework 101 #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kfr-odoo
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Keep going, just a few remarks
- Ensure your commits respects Odoo's guidelines
- Configure your IDE to get ride of EOF issues. "Insert Final Newline" in VScode.
kfr-odoo
reviewed
Dec 18, 2024
| <record id="estate_property_type_action" model="ir.actions.act_window"> | ||
| <field name="name">Property Types</field> | ||
| <field name="res_model">estate.property.type</field> | ||
| <field name="view_mode">list,form</field> |
There was a problem hiding this comment.
FYI: this is the default. Not a bad practice to have it here anyway. ref
kfr-odoo
reviewed
Dec 19, 2024
…ew Application, and Chapter 3: Models And Basic Fields
ataha1
force-pushed
the
18.0-training-ahta
branch
from
75e607d to
ebc6946
Compare
kfr-odoo
reviewed
Dec 20, 2024
kfr-odoo
reviewed
Dec 23, 2024
kfr-odoo
approved these changes
Dec 27, 2024
Comment on lines
+12
to
+13
| if (this.props.onChange) { | ||
| this.props.onChange(); |
There was a problem hiding this comment.
FYI: this syntax works also
Suggested change
| if (this.props.onChange) { | |
| this.props.onChange(); | |
| this.props.onChange?.(); |
| @api.model_create_multi | ||
| def create(self, vals_list): | ||
| for vals in vals_list: | ||
| property = self.env["estate.property"].browse(vals["property_id"]) |
There was a problem hiding this comment.
Suggested change
| property = self.env["estate.property"].browse(vals["property_id"]) | |
| property = self.env["estate.property"].browse(vals["property_id"]).exists() |
| @@ -0,0 +1,2 @@ | |||
| id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink | |||
| estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.