Master no shared borders rar #5452
Open
+288
−390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rrahir
force-pushed
the
master-no-shared-borders-rar
branch
6 times, most recently
from
201c3d3 to
80de593
Compare
Currently, the borders are defined as a "vertical" and "horizontal" property on each cell and are shared through adjacent cells. E.g. The bottom border defined on `A1` is functionally also the top border of `A2` (see commit 9747294) for more info) This approach is not shared with other spreadsheet engines,be it Excel or GSheet. In their case, each cell has their own independant border and follows a simple rule: - setting the border of a cell will erase the border of the adjacent cell IIF the borders differ, i.e. Have a different color and/or style. E.g. - On A2, add an "all" blue border - on A1, add a bottom blue border - on A3, add a top red border By inserting rows between rows 1-2 and rows 2-3, you can see that A2 still has a top border but it no longer has a bottom border. This revision changes the internal structure of the border plugin to align our behaviour with the other spreadsheet engines. Task: 4458245
rrahir
force-pushed
the
master-no-shared-borders-rar
branch
from
80de593 to
2e5bc12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist