Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect also the LogRecord within the hint when filter for sentry #740

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

burnout87
Copy link
Collaborator

No description provided.

@burnout87 burnout87 changed the title inspect also the LogRecord within the hint when filter for sentry inspect also the LogRecord within the hint when filter for sentry Feb 3, 2025
@burnout87 burnout87 self-assigned this Feb 3, 2025
Copy link
Member

@dsavchenko dsavchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it was sent twice because of sentry-logger integration.
Do we need a send_message then overall?

Anyway, approving as it works.

@burnout87
Copy link
Collaborator Author

burnout87 commented Feb 3, 2025

Do we need a send_message then overall?

Good question. Probably not really in this case, but then it would imply refactoring at many levels

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.33%. Comparing base (662bccc) to head (7e7e219).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
+ Coverage   62.31%   62.33%   +0.01%     
==========================================
  Files          51       51              
  Lines        9177     9181       +4     
==========================================
+ Hits         5719     5723       +4     
  Misses       3458     3458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burnout87 burnout87 merged commit 0d076be into master Feb 3, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't send specific issue class raised in the backend to Sentry
3 participants