Add localtime docs about timezones (inc. pitfalls) #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthorner
force-pushed
the
localtime/dst-warning
branch
3 times, most recently
from
c636a5e to
7c21694
Compare
jarshwah
reviewed
Dec 19, 2024
| # only one hour elapsed for the rest of the world. | ||
| localtime.as_utc(datetime(2020, 3, 29, hour=2, tzinfo=london_tz)) - | ||
| localtime.as_utc(datetime(2020, 3, 29, hour=0, tzinfo=london_tz)) | ||
| => timedelta(seconds=3600) |
There was a problem hiding this comment.
Is this right? This is showing 1 hour
There was a problem hiding this comment.
The example is accurate, yes:
- 2AM GBR => 1AM UTC
- 0AM GBR => 0AM UTC
I've elaborated the comment a bit; does that help?
Comment on lines
+64
to
+71
| datetime(2020, 3, 29, hour=2, tzinfo=london_tz) - | ||
| datetime(2020, 3, 29, hour=1, tzinfo=london_tz) | ||
| => datetime.timedelta(seconds=3600) # <== WRONG (should be 0) | ||
| ``` |
There was a problem hiding this comment.
This section is confusing, it's not obvious why it's wrong
There was a problem hiding this comment.
I've elaborated the comment a bit; does that help?
Maybe this example just isn't a good fit here. I think it's important knowledge, so I'd like to put it somewhere.
benthorner
force-pushed
the
localtime/dst-warning
branch
from
7c21694 to
6b3363f
Compare
In response to [^1]. [^1]: #178 (comment)
benthorner
force-pushed
the
localtime/dst-warning
branch
from
6b3363f to
11a881e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to 1.
👉 Markdown rendered version
Footnotes
https://github.com/octoenergy/xocto/pull/178#discussion_r1875190812 ↩