Various runtime fixes #1825
Merged
Various runtime fixes #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- compiler/tests-io/dune: Language not supported
- compiler/tests-io/non_ascii_filenames.expected: Language not supported
- compiler/tests-io/non_ascii_filenames.ml: Language not supported
- runtime/js/unix.js: Evaluated as low risk
Comments suppressed due to low confidence (4)
runtime/js/fs.js:216
- [nitpick] Ensure the new error message 'ENOTDIR: not a directory, chdir' is clear and helpful.
caml_raise_sys_error("ENOTDIR: not a directory, chdir '" + caml_jsstring_of_string(dir) + "'");
runtime/js/fs.js:209
- Ensure the new behavior introduced in caml_sys_chdir is covered by tests.
if (root.device.is_dir(root.rest)) {
runtime/js/io.js:93
- The removal of the compatibility check for Open_rdonly and Open_wronly flags may lead to unclear error states if these checks are not handled elsewhere in the codebase.
if (f.rdonly && f.wronly)
runtime/js/io.js:96
- The removal of the compatibility check for Open_text and Open_binary flags may lead to unclear error states if these checks are not handled elsewhere in the codebase.
if (f.text && f.binary)
hhugo
reviewed
Feb 3, 2025
hhugo
reviewed
Feb 3, 2025
I don't mind minor releases if something break. Can you update CHANGES.md ? |
In particular: - I'm not sure inconsistent flags when opening a file should result in a failure - I suspect fs.writeSync does not always write everything - Unix.getuid should not fail - The target of Unix.symlink is just some arbitrary text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hhugo I'm a bit worried of making large changes right before a release. So, if you are unsure of some of the changes, I can just omit them.