Run all tests with double translation too #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
reviewed
Jan 28, 2025
vouillon
reviewed
Jan 28, 2025
vouillon
force-pushed
the
more-tests-double-translation
branch
5 times, most recently
from
73fa4f8 to
e9e9feb
Compare
|
@vouillon It looks like you have erased some of my commits when force-pushing. I’ll re-add them on top when the CI has finished. |
vouillon
reviewed
Jan 29, 2025
vouillon
approved these changes
Jan 29, 2025
vouillon
reviewed
Feb 3, 2025
hhugo
force-pushed
the
more-tests-double-translation
branch
from
998cf47 to
db9c1d2
Compare
hhugo
reviewed
Feb 3, 2025
|
I've pushed a commit to have tests-dynlink-js and lwt_toplevel work with double-translation. |
|
manual/effects.wiki is outdated regarding dune support, can someone update it either in this PR or in a separate one ? We need this before the 6.0 release. |
Co-authored-by: Jérôme Vouillon <[email protected]>
hhugo
force-pushed
the
more-tests-double-translation
branch
from
e6c9953 to
d44c7ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires some care to avoid Dune setting the flag
--effects=twice.