Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1387: [Lake] Reintroduce truevals #1461

Closed
wants to merge 242 commits into from
Closed

Fix #1387: [Lake] Reintroduce truevals #1461

wants to merge 242 commits into from

Conversation

idiom-bytes
Copy link
Member

@idiom-bytes idiom-bytes commented Jul 25, 2024 •
edited
Loading

Description

Fixes #1387: Reintroduce truevals

I have converted this PR to a draft as i'm blocked until these PR dependencies are merged.

After these dependencies are merged, I can branch again from main + cherry-pick my work into a clean PR for review

DoD

  • I've updated all tests to pass
  • Fixtures have been updated with data after subgraph issue
  • Removed old tests that do not apply any longer
  • Updated diagram and images for documentation

kdetry added 30 commits February 21, 2024 12:27
@kdetry
issue-617 Base Class
a835234
@kdetry
issue617 - Persistent Data Store
f6cc990
@kdetry
duckdb dependency is added to setup.py
ac81100
@kdetry
dry fix
6ffc626
@kdetry
Merge branch 'main' into issue617
0914085
@kdetry
CSV data handler - part 1
1e3892b
@kdetry
csv data store - fill with zero
3670826
@kdetry
table csv integration
b324491
@kdetry
test fix - 1
c2c4e81
@kdetry
fixing tests - 2
1b118ae
@kdetry
test fixes - 3
4e4687b
@kdetry
Merge branch 'main' into issue617
a56c5ae
@kdetry
black fix
4582fe3
@kdetry
take-back the gql_data_factory from the main branch
494135b
@kdetry
pylint issues
6c5ebfe
@kdetry
issue681 - check fixes
e57000b
@kdetry
test fixes
3940917
@kdetry
Merge branch 'main' into issue681
99b97a5
@kdetry
Merge branch 'main' into issue681
bb5d74d
@kdetry
Merge branch 'main' into issue681
817c882
@kdetry
Merge branch 'main' into issue681
c919b1b
@kdetry
issue681 - Append Logic
bb4a2dc
@kdetry
Merge branch 'issue681' of https://github.com/oceanprotocol/pdr-backend…
fecfb25 
… into issue681
@kdetry
black pylint fix
e8c5843
@kdetry
issue681 _append_to_csv
db99f6e
@kdetry
issue681 - black fix
d546816
@kdetry
Merge branch 'issue681' into issue685
70791a3
@kdetry
Merge branch 'issue617' into issue685
c345615
@kdetry
issue685 - integration with 681 and 617
2df30f8
@kdetry
issue681 - black pylint fixes
c84d85f
idiom-bytes and others added 24 commits July 23, 2024 18:49
@idiom-bytes
fixing other issues so i can revert
10562f5
@idiom-bytes
Revert "fixing other issues so i can revert"
de332c2 
This reverts commit 10562f5.
@idiom-bytes
Merge branch 'issue1387-reintroduce-truevals' of github.com:oceanprot…
94080fa 
…ocol/pdr-backend into issue1387-reintroduce-truevals
@idiom-bytes
cleaning up old prints and comments
4c455e8
@idiom-bytes
implementing calinas feedback
cd7c65c
@idiom-bytes
fixing formatting
ade35ce
@idiom-bytes
Merge branch 'main' into issue1001-incremental-etl
0c4dd54
@idiom-bytes
hooks for new fixture data (when possible)
2b90a58
@calina-c
Merge branch 'main' into issue1001-incremental-etl
8549a2d
@idiom-bytes
fixing small issues that are keeping lake from running correctly
0bcc67c
@idiom-bytes
fix black
5a5b373
@idiom-bytes
Merge branch 'main' into issue1001-incremental-etl
1850174
@idiom-bytes
fixing pylint
d2b82f5
@idiom-bytes
Merge branch 'issue1457-fix-lake' into issue1001-incremental-etl
02bbce5
@idiom-bytes
Merge branch 'main' into issue1457-fix-lake
37a9bed
@idiom-bytes
reverting check_network issue
32e0e69
@idiom-bytes
Merge branch 'main' into issue1001-incremental-etl
ad2a2ac
@idiom-bytes
Merge branch 'issue1457-fix-lake' into issue1001-incremental-etl
b5feb0e
@idiom-bytes
there was an extra row_count
d4e671a
@idiom-bytes
fixing formatting
e151362
@idiom-bytes
merging from 1001-incremental-etl
77556bf
@idiom-bytes
updating fixture and sample data
95cfe09
@idiom-bytes
updating old mock objects
7dfc868
@idiom-bytes
updating lake diagrams and documentation to match latest tables and s…
7163abc 
…chemas
@idiom-bytes idiom-bytes marked this pull request as draft July 25, 2024 22:25
@idiom-bytes idiom-bytes mentioned this pull request Jul 31, 2024
Merged
4 tasks
@idiom-bytes idiom-bytes deleted the issue1387-reintroduce-truevals branch July 31, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ETL] Reintroduce truevals into ETL
4 participants
@idiom-bytes @kdetry @KatunaNorbert @calina-c