Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1375: [PdrDashboard] Enhance Table Functionality - Add Buttons and Sorting #1379

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

kdetry
Copy link
Contributor

@kdetry kdetry commented Jul 10, 2024

Fix #1375: Enhance Table Functionality - Add Buttons and Sorting

Changes proposed in this PR:

  • Select All and Clear buttons
  • Sorting
  • Tests
  • UI changes on view_elements

@kdetry kdetry changed the title issue-1375: Enhance Table Functionality - Add Buttons and Sorting Fix #1375: [PdrDashboard] Enhance Table Functionality - Add Buttons and Sorting Jul 10, 2024
@kdetry kdetry changed the base branch from main to issue-1357-PdrDashboard-v02 July 10, 2024 13:48
@kdetry kdetry requested review from KatunaNorbert and calina-c July 11, 2024 10:27
],
[
State("predictoors_table", "data"),
State("predictoors_table", "selected_rows"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the selected rows inside the callbacks, from what I see they are not used

@kdetry kdetry merged commit 6f49adc into issue-1357-PdrDashboard-v02 Jul 11, 2024
4 checks passed
@kdetry kdetry deleted the issue-1375 branch July 11, 2024 14:03
KatunaNorbert added a commit that referenced this pull request Jul 22, 2024
* Fix #1376: Change callbacks to not store payout data (#1378)

* Fix #1375: Add Buttons and Sorting (#1379)

* Fix #1373: Separate some concerns in pdr-dashboard. (#1390)

* Fix #1374: Display metrics over multiple feeds and predictoors (#1377)

* Fix #1400: Fix selections in feed and predictoor list (#1401)

* Fix #1385: Add switch to display selected predictoors feeds only (#1395)

* Fix #1402: Allow address config for predictoor dashboard. (#1403)

* Fix #1404: Allow date period selection (#1405)

* Fix #1384: Improve predictoors table by adding accuracy, stake and profit (#1398)

* Fix #1409: Add predictoor and feed startup data instead of loading on a dash component (#1411)

* Fix #1412:  Update dashboard readme with new instructions (#1414)

* Fix #1413: Update and split dash_duo tests (#1417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PdrDashboard, v0.2] Enhance Table Functionality - Add Buttons and Sorting
2 participants