Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unused vars #286

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Removing unused vars #286

merged 4 commits into from
Feb 29, 2024

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Feb 27, 2024 •
edited
Loading

Fixes #285

Changes proposed in this PR:

  • Changing ESLint rules to throw an error if an unused variable is introduced
  • All unused vars have either been removed, commented out or the rule is disabled where necessary

@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review February 27, 2024 14:23
paulo-ocean
paulo-ocean approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mariacarmina
mariacarmina approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamiehewitt15 jamiehewitt15 merged commit d25ff70 into develop Feb 29, 2024
6 checks passed
@jamiehewitt15 jamiehewitt15 deleted the removing-unused-vars branch February 29, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@mariacarmina mariacarmina mariacarmina approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@bogdanfazakas bogdanfazakas Awaiting requested review from bogdanfazakas bogdanfazakas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamiehewitt15 @mariacarmina @paulo-ocean