Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 packages from ocsigen/lwt at 5.8.1 #27204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

raphael-proust
Copy link
Contributor

This pull-request concerns:

  • lwt.5.8.1: Promises and event-driven I/O
  • lwt_ppx.5.8.1: PPX syntax for Lwt, providing something similar to async/await from JavaScript


🐫 Pull-request generated by opam-publish v2.4.0

@raphael-proust
Copy link
Contributor Author

do not merge: doesn't seem to fix the issue this release aims to address (ocsigen/lwt#1042)

@raphael-proust
Copy link
Contributor Author

fixed the issue now

@shonfeder
Copy link
Contributor

Builds seem to be failing with variations of

#=== ERROR while compiling lwt_ppx.5.8.1 ======================================#
# context              2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.5.2.1 | pinned(https://github.com/ocsigen/lwt/archive/refs/tags/5.8.1.tar.gz)
# path                 ~/.opam/5.2/.opam-switch/build/lwt_ppx.5.8.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p lwt_ppx -j 255 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/lwt_ppx-7-016b47.env
# output-file          ~/.opam/log/lwt_ppx-7-016b47.out
### output ###
# (cd _build/default && /home/opam/.opam/5.2/bin/ocamlc.opt -w -40 -warn-error -22 -g -bin-annot -bin-annot-occurrences -I test/ppx/.main.eobjs/byte -I /home/opam/.opam/5.2/lib/bytes -I /home/opam/.opam/5.2/lib/lwt -I /home/opam/.opam/5.2/lib/lwt/unix -I /home/opam/.opam/5.2/lib/ocaml/threads -I /home/opam/.opam/5.2/lib/ocaml/unix -I /home/opam/.opam/5.2/lib/ocplib-endian -I /home/opam/.opam/5.2/lib/ocplib-endian/bigstring -I test/.lwttester.objs/byte -no-alias-deps -o test/ppx/.main.eobjs/byte/dune__exe__Main.cmo -c -impl test/ppx/main.pp.ml)
# File "test/ppx/main.ml", line 9, characters 0-46:
# 9 | let%lwt structure_let_result = Lwt.return_true
#     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Warning 22 [preprocessor]: let%lwt should not be used at the module item level.
# Replace let%lwt x = e by let x = Lwt_main.run (e)
# (cd _build/default && /home/opam/.opam/5.2/bin/ocamlopt.opt -w -40 -warn-error -22 -g -I test/ppx/.main.eobjs/byte -I test/ppx/.main.eobjs/native -I /home/opam/.opam/5.2/lib/bytes -I /home/opam/.opam/5.2/lib/lwt -I /home/opam/.opam/5.2/lib/lwt/unix -I /home/opam/.opam/5.2/lib/ocaml/threads -I /home/opam/.opam/5.2/lib/ocaml/unix -I /home/opam/.opam/5.2/lib/ocplib-endian -I /home/opam/.opam/5.2/lib/ocplib-endian/bigstring -I test/.lwttester.objs/byte -I test/.lwttester.objs/native -intf-suffix .ml -no-alias-deps -o test/ppx/.main.eobjs/native/dune__exe__Main.cmx -c -impl test/ppx/main.pp.ml)
# File "test/ppx/main.ml", line 9, characters 0-46:
# 9 | let%lwt structure_let_result = Lwt.return_true
#     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
# Warning 22 [preprocessor]: let%lwt should not be used at the module item level.
# Replace let%lwt x = e by let x = Lwt_main.run (e)
# (cd _build/default/test/ppx && ./main.exe)
# Testing library 'ppx'...
# ................
# Ok. 16 tests ran, 0 tests skipped in 1.20 seconds
# File "test/unix/dune", line 22, characters 7-11:
# 22 |  (name main)
#             ^^^^
# (cd _build/default/test/unix && ./main.exe)
# Testing library 'unix'...
# .....................................SSSSS..................................................................................................E............SSSSE..................................................................................
# Test 'bytes read' in suite 'lwt_bytes' raised 'Unix.Unix_error(Unix.ENOENT, "open", "bytes_io_data")'
# Test 'map_file' in suite 'lwt_bytes' raised 'Unix.Unix_error(Unix.ENOENT, "open", "bytes_io_data")'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants