Release ppxlib.0.34.0 and ppxlib-tools.0.34.0 #27141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
reviewed
Dec 19, 2024
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
release-ppxlib-0.34.0
branch
from
38dd275 to
1e5d255
Compare
|
Sorry for the delay, thought I could get this through before leaving for the end of year holidays! Diving into the rev-deps failure and hopefully undrafting this today! |
|
From a quick look I couldn't spot anything that seems related to the changes in ppxlib so I'll proceed with the full release. Please let me know if you manage to spot something I missed! |
Signed-off-by: Nathan Rebours <[email protected]>
Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
changed the title
|
@kit-ty-kate do you think this is good to go? |
|
I'm not really the one to ask (opam-repository maintainers are) but i have no objections. lgtm ofc |
|
Ah my bad! |
|
looks good to me too |
|
I was going through the failures and looks all right also to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES:
5.3 support
Add initial OCaml 5.3 support (Add support for latest trunk (5.03) ocaml-ppx/ppxlib#487, @NathanReb, @hhugo, @nojb)
Initialise OCaml 5.3's lexer with the
keywordssetting fromOCAMLPARAMor the new-keywordsdriver's CLI option to allow the standalone ppx driver to process old packages usingeffectas an identifier (PoC: support OCaml 5.3'skeywordsentry inOCAMLPARAMocaml-ppx/ppxlib#535, @dra27, @NathanReb)Other changes
Add
Pprintast.binding,longidentandpayload(Add missing functions to pprintast (binding, longindent, payload) ocaml-ppx/ppxlib#542, @mattiasdrp)Fix
deriving_inlineround-trip check so that it works with 5.01 <-> 5.02 migrations (Fix roundtrip check to support 5.1 <-> 5.2 migrations ocaml-ppx/ppxlib#519, @NathanReb)Add ppxlib's AST pretty-printing utilities in
Ppxlib.Pp_astand appxlib-pp-astexecutable in a new separateppxlib-toolspackage (Add Pp_ast module and ppxlib-pp-ast executable for pretty-printing ppxlib ASTs ocaml-ppx/ppxlib#517, Filter out floating attributes in Pp_ast ocaml-ppx/ppxlib#525, Add Submodules with simpler APIs to Pp_ast ocaml-ppx/ppxlib#537, @NathanReb)Change
-dparsetreefrom a sexp output to a pretty printed AST, closer to what the compiler's-dparsetreeis.(Replace -dparsetree sexp output with a pretty-printed AST ocaml-ppx/ppxlib#530, @NathanReb)
Add Parsetree documentation comments to
Ast_builderfunctions (Ast_builder documentation ocaml-ppx/ppxlib#518, @patricoferris)Support class type declarations in derivers with the new, optional arguments
{str,sig}_class_type_declinDeriving.add(Support class type declarations in derivers ocaml-ppx/ppxlib#538, @patricoferris)